propertynames for PyNULL (JuliaPy#707)

simeonschaub · Aug 14, 2019 · 6dcf5c2 · 6dcf5c2
1 parent cf01bf0
commit 6dcf5c2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/PyCall.jl b/src/PyCall.jl
@@ -305,8 +305,7 @@ end
 
 getproperty(o::PyObject, s::Symbol) = convert(PyAny, getproperty(o, String(s)))
 
-propertynames(o::PyObject) = map(x->Symbol(first(x)),
-                                pycall(inspect."getmembers", PyObject, o))
+propertynames(o::PyObject) = ispynull(o) ? Symbol[] : map(x->Symbol(first(x)), pycall(inspect."getmembers", PyObject, o))
 
 # avoiding method ambiguity
 setproperty!(o::PyObject, s::Symbol, v) = _setproperty!(o,s,v)

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -345,6 +345,7 @@ const PyInt = pyversion < v"3" ? Int : Clonglong
     @test ispynull(PyNULL())
     @test !ispynull(PyObject(3))
     @test ispynull(pydecref(PyObject(3)))
+    @test isempty(propertynames(PyNULL()))
 
     ex = try
         pyimport("s p a m")