Update sites.js #69
Merged
Update sites.js #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eager-mccarthy-ee07e5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
simcard0000
requested changes
Jun 4, 2024
There was a problem hiding this comment.
Hey @elijah0528! Thanks for submitting a PR. Two nits:
- Add your site entry to the end of the
allSitesarray in thesites.jsfile (instead of the start). - Could you link back to the webring somewhere on your site if possible?
|
Hey Simran – Made these changes to the sites.js! SE Webring will be pushed with my latest updates to my website where I flesh out each of my experiences. Is this okay? |
|
@elijah0528 Thanks for the updates! Yeah, as long as you eventually add a link back to the webring somewhere on your site you should be fine. |
simcard0000
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To add your site to the webring, you must be a current student or an alum of the undergraduate Software Engineering program at the University of Waterloo (Waterloo, ON, Canada).
Full Name: Elijah Kurien
Cohort Year: 2028
Full website URL: elijahkurien.com
So we know you're human:
LinkedIn or a similar profile: https://www.linkedin.com/in/elijahkurien/