Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add site: Ishaan Dey #54

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Add site: Ishaan Dey #54

merged 2 commits into from
Jan 10, 2024

Conversation

ishaan1013
Copy link
Contributor

To add your site to the webring, you must be a current student or an alum of the undergraduate Software Engineering program at the University of Waterloo (Waterloo, ON, Canada).

Full Name: Ishaan Dey

Cohort Year: 2028

Full website URL: https://www.ishaand.com

So we know you're human:

LinkedIn or a similar profile: https://www.linkedin.com/in/ishaan1013

Don't forget to also add your entry to the end of the allSites array in the se-webring.js file (name, year, personal website)!

Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for eager-mccarthy-ee07e5 ready!

Name Link
🔨 Latest commit c3b8852
🔍 Latest deploy log https://app.netlify.com/sites/eager-mccarthy-ee07e5/deploys/659dca6692f3dd00081c9bcb
😎 Deploy Preview https://deploy-preview-54--eager-mccarthy-ee07e5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the add site Add a new website to the webring label Jan 9, 2024
Copy link
Owner

@simcard0000 simcard0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! Everything looks LGTM, except could you add a link/icon back to the webring somewhere on your site? Thanks!

@ishaan1013
Copy link
Contributor Author

Done, it's in the footer

@simcard0000 simcard0000 self-requested a review January 10, 2024 22:50
Copy link
Owner

@simcard0000 simcard0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@simcard0000 simcard0000 merged commit 99a8470 into simcard0000:main Jan 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add site Add a new website to the webring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants