Refactoring the test

silviolleite · Apr 15, 2019 · c09cc07 · c09cc07
1 parent a193e1b
commit c09cc07
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 12 deletions.
diff --git a/tests/test_template.py b/tests/test_template.py
@@ -1,10 +1,12 @@
-from django.test import TestCase
-from django.template import Context, Template
+from django.test import TestCase, RequestFactory
+from django.template import Template, RequestContext
 
 
 class TemplateTagTest(TestCase):
     def setUp(self):
-        context = Context({})
+        self.factory = RequestFactory()
+        request = self.factory.get('/teste')
+        context = RequestContext(request=request)
         template_to_render = Template(
             '{% load flags %}'
             '{% languages %}'
@@ -15,8 +17,8 @@ def test_has_tags(self):
         """Must contains the tags in HTML"""
         tags = (
             '<li',
-            '<a tabindex="-1" href="#pt-br"',
-            '<a tabindex="-1" href="#en"',
+            '<a href="#pt-br"',
+            '<a href="#en"',
             '<span class="flag-icon flag-icon-pt-br',
             '<span class="flag-icon flag-icon-en'
         )
@@ -56,7 +58,9 @@ def test_has_no_class_square(self):
 
 class TemplatetagWithSquareTest(TestCase):
     def setUp(self):
-        context = Context({})
+        self.factory = RequestFactory()
+        request = self.factory.get('/teste')
+        context = RequestContext(request=request)
         template_to_render = Template(
             '{% load flags %}'
             "{% languages 'square'  %}"
@@ -75,7 +79,9 @@ def test_count_class(self):
 
 class TemplatetagWithKwargsTest(TestCase):
     def setUp(self):
-        context = Context({})
+        self.factory = RequestFactory()
+        request = self.factory.get('/teste')
+        context = RequestContext(request=request)
         template_to_render = Template(
             '{% load flags %}'
             "{% languages 'square' li_class='your-li-class' a_class='your-a-class' %}"

diff --git a/tests/test_template_tag.py b/tests/test_template_tag.py
@@ -1,14 +1,18 @@
-from django.test import TestCase
+from django.template import Context, Template, RequestContext
+from django.test import TestCase, RequestFactory
 
 from django_translation_flags.templatetags.flags import languages
 
 
 class TemplateTagFlagTest(TestCase):
     def setUp(self):
-        self.languages = languages()
+        self.factory = RequestFactory()
+        request = self.factory.get('/teste')
+        context = RequestContext(request=request)
+        self.languages = languages(context)
 
     def test_languages_return_has_key(self):
-        expected = ['icon_class', 'classes']
+        expected = ['icon_class', 'classes', 'redirect_to']
         self.assertListEqual(expected, list(self.languages.keys()))
 
     def test_languages_return_has_classes_key(self):
@@ -30,7 +34,10 @@ def test_languages_return_a_class(self):
 
 class TemplateTagFlagTypeTest(TestCase):
     def setUp(self):
-        self.languages = languages('square')
+        self.factory = RequestFactory()
+        request = self.factory.get('/teste')
+        context = RequestContext(request=request)
+        self.languages = languages(context, 'square')
 
     def test_languages_return_flag_type_square(self):
         """Must return the class flag-icon-square when given the string 'square' as param"""
@@ -39,7 +46,14 @@ def test_languages_return_flag_type_square(self):
 
 class TemplateTagKwargsTest(TestCase):
     def setUp(self):
-        self.languages = languages(li_class='your-li-class', a_class='your-a-class')
+        self.factory = RequestFactory()
+        template = Template(
+            '{% load flags %}'
+            "{% languages 'square' li_class='your-li-class' a_class='your-a-class' %}"
+        )
+        request = self.factory.get('/teste')
+        context = RequestContext(request=request)
+        self.languages = languages(context=context, li_class='your-li-class', a_class='your-a-class')
 
     def test_languages_return_li_class(self):
         """Must return class when given the key li_class"""