Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SF-3127 Fix horizontal line appearing on home page #2947

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

josephmyers
Copy link
Collaborator

@josephmyers josephmyers commented Jan 14, 2025

This fixes an issue where the background is shown just above/behind this element at some resolutions.


This change is Reviewable

This fixes an issue where the background is shown just above/behind this element at some resolutions.
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.89%. Comparing base (de83faa) to head (7e2eb8d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2947   +/-   ##
=======================================
  Coverage   80.89%   80.89%           
=======================================
  Files         533      533           
  Lines       31262    31262           
  Branches     5088     5066   -22     
=======================================
  Hits        25288    25288           
- Misses       5211     5223   +12     
+ Partials      763      751   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josephmyers josephmyers marked this pull request as ready for review January 14, 2025 08:20
@Nateowami
Copy link
Collaborator

@josephmyers It took me a good minute or two of looking at this to figure out what this was even about. I thought the "book curve" was probably something about the border radius when selecting books for drafting.

In our CONTRIBUTING.md, there's a bullet point that says "Contextualize the change, even at the cost of being less specific."

A better title would be something like "Fix line appearing on home page"

In the past I've been able to reproduce this bug, but today I can't, so I can't really review this.

Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not reproducing this bug either, but I can play around with it in dev tools and can see why this would fix the line. I'll approve and let you merge it after updating the title.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @josephmyers)

@Nateowami Nateowami changed the title SF-3127 Shift book curve up a pixel SF-3127 Fix horizontal line appearing on home page Jan 14, 2025
@Nateowami Nateowami merged commit 56d272a into master Jan 14, 2025
17 checks passed
@Nateowami Nateowami deleted the fix/SF-3127 branch January 14, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants