Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2 for #595 - make sure Name field is always there. #603

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Jan 21, 2025

Fix for #595

  • The "OK" is not needed but will be auto-added.
  • If "Name" is not there, it will crash when trying to get the fields.

This change is Reviewable

* The "OK" is not needed but will be auto-added.
* If "Name" is not there, it will crash when trying to get the fields.
@johnml1135 johnml1135 requested a review from Enkidu93 January 21, 2025 16:31
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.49%. Comparing base (f5f4244) to head (da134f7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
+ Coverage   64.48%   64.49%   +0.01%     
==========================================
  Files         280      280              
  Lines       14105    14112       +7     
  Branches     1824     1824              
==========================================
+ Hits         9096     9102       +6     
  Misses       4348     4348              
- Partials      661      662       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Another issue connected to #567

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@johnml1135 johnml1135 merged commit 4c07449 into main Jan 21, 2025
3 checks passed
@johnml1135 johnml1135 deleted the get_all_copora_fix branch January 21, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants