no pretranslations written

[johnml1135]

Fix for #601 - Make sure you flush!

---

This change is 

[ddaspit]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93 and @johnml1135)

---

src/Machine/src/Serval.Machine.Shared/Services/MessageOutboxService.cs line 90 at r1 (raw file):

            await contentStream.CopyToAsync(fileStream, cancellationToken);
            await fileStream.FlushAsync(cancellationToken);
            await fileStream.DisposeAsync();

Instead of explicitly calling dispose, we should scope the using block properly.

[johnml1135]

src/Machine/src/Serval.Machine.Shared/Services/MessageOutboxService.cs line 90 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

Instead of explicitly calling dispose, we should scope the using block properly.

Is that what you were thinking about?

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.48%. Comparing base (a4203cf) to head (8c0cfbc).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #602   +/-   ##
=======================================
  Coverage   64.48%   64.48%           
=======================================
  Files         280      280           
  Lines       14105    14105           
  Branches     1825     1823    -2     
=======================================
+ Hits         9095     9096    +1     
+ Misses       4349     4348    -1     
  Partials      661      661           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ddaspit]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93 and @johnml1135)

---

src/Machine/src/Serval.Machine.Shared/Services/MessageOutboxService.cs line 90 at r1 (raw file):

Previously, johnml1135 (John Lambert) wrote…

Is that what you were thinking about?

Yes. It should be an await using.

[johnml1135]

src/Machine/src/Serval.Machine.Shared/Services/MessageOutboxService.cs line 90 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

Yes. It should be an await using.

Done.

[ddaspit]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved