Pass a content fragment to AddLexReferences() #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converting the fragment to a string was resulting in the loss of all styling for Word Export. Now we pass the content fragment to AddLexReferences() and let the xhtml and json generators do the conversion to a string. Change-Id: I0574ae94317c1580894e944429432ea4d56c99c6
Converting the fragment to a string was resulting in the loss of all styling for Word Export. Now we pass the content fragment to both AddLexReferences() and AddCollection(). The xhtml and json generators do the conversion to a string. Change-Id: I6979ba8b706fae29a4d99ac980e7d8396038c181
mark-sil
commented
May 28, 2024
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mark-sil)
|
These changes were included in Commit 119a4e2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting the fragment to a string was resulting in the loss of all styling for Word Export. Now we pass the content fragment to AddLexReferences() and let the xhtml and json generators do the conversion to a string.
This change is