Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reversal export naming & don't export empty reversals #41

Merged
merged 2 commits into from
May 3, 2024
Merged

Fix reversal export naming & don't export empty reversals #41

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db54be6
Fix reversal export naming & don't export empty reversals
aror92 May 3, 2024
45fc583
Merge branch 'release/9.1' into bugfix/reversalExport
jasonleenaylor May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Src/xWorks/DictionaryExportService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,15 @@ public void ExportReversalForWord(string filePath, string reversalWs, Dictionary
configuration = configuration ?? new DictionaryConfigurationModel(
DictionaryConfigurationListener.GetCurrentConfiguration(m_propertyTable, "ReversalIndex"), m_cache);
var publicationDecorator = ConfiguredLcmGenerator.GetPublicationDecoratorAndEntries(m_propertyTable, out var entriesToSave, ReversalType);

// Don't export empty reversals
if (entriesToSave.Length == 0)
return;

if (progress != null)
progress.Maximum = entriesToSave.Length;

string reversalFilePath = filePath.Split(new string[] { ".docx"}, StringSplitOptions.None)[0] + "-" + reversalWs + ".docx";
string reversalFilePath = filePath.Split(new string[] { ".docx"}, StringSplitOptions.None)[0] + "-reversal-" + reversalWs + ".docx";

LcmWordGenerator.SavePublishedDocx(entriesToSave, publicationDecorator, int.MaxValue, configuration, m_propertyTable, reversalFilePath, progress);
}
Expand Down
Loading