Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LT-21999: Improve saving of parser test reports #224

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

jtmaxwell3
Copy link
Collaborator

@jtmaxwell3 jtmaxwell3 commented Dec 5, 2024

This implements https://jira.sil.org/browse/LT-21999 with Jason's permission.
It adds a "Save Report" button to the window for individual parser reports.
It adds the comment as a label right after Save Report button.
It changes saving so that you can change a comment by saving the report again (deleting the old report).
It also fixes a bug that prevented comment fields from being updated properly when comments are changed.


This change is Reviewable

@jasonleenaylor
Copy link
Contributor

Src/LexText/ParserUI/ParserReportDialog.xaml line 19 at r1 (raw file):

		<Grid.RowDefinitions>
			<RowDefinition Height="*" />
			<RowDefinition Height="Auto" />

These are reversed from what I would expect, and it might explain why the Save button looks like it is cut off at the bottom.
Does it look better if they are swapped?

@JakeOliver28 JakeOliver28 enabled auto-merge (squash) December 6, 2024 17:17
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)

@JakeOliver28 JakeOliver28 merged commit 513d565 into release/9.1 Dec 6, 2024
5 checks passed
@JakeOliver28 JakeOliver28 deleted the LT-21999 branch December 6, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants