Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 6.7.1 -- better error, and auto-generate release string #331

Merged
merged 6 commits into from
Apr 5, 2024
Merged

Release 6.7.1 -- better error, and auto-generate release string #331

merged 6 commits into from
Apr 5, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Apr 5, 2024

Added

  • Get the release tag from GitHub for use in the Sentry release string

Fixed

  • Fail earlier and produce a more appropriate error message if employee_id is not found.
  • README correction

@briskt briskt requested a review from a team April 5, 2024 15:27
jason-jackson
jason-jackson approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@jason-jackson jason-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I'll have another PR probably later today if you want to hold off on the release to include that as well.

@briskt
Copy link
Contributor Author

briskt commented Apr 5, 2024

Approved, but I'll have another PR probably later today if you want to hold off on the release to include that as well.

I'm ok with smaller releases. Knowing another is coming, I won't deploy this to the masses of IdP instances, though.

@briskt briskt merged commit 075517e into main Apr 5, 2024
6 checks passed
@briskt briskt deleted the release/6.7.1 branch April 5, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-jackson jason-jackson jason-jackson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @jason-jackson