This repository has been archived by the owner on Feb 7, 2025. It is now read-only.
Use GitHub actions #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-jackson
commented
Feb 22, 2024
| - name: Build and push Docker image | ||
| uses: docker/build-push-action@v5 | ||
| with: | ||
| context: . |
There was a problem hiding this comment.
I am curious if this is needed, see docs:
| context | String | Build's context is the set of files located in the specified PATH or URL(default Git context) |
|---|
context String Build's context is the set of files located in the specified PATH or URL (default Git context)
briskt
approved these changes
Feb 22, 2024
| x-common-variables: &test-variables | ||
| HOST: http://testapp | ||
| COOKIE_NAME: _proxy | ||
| TOKEN_SECRET: Rm9yIEdvZCBzbyBsb3ZlZCB0aGUgd29ybGQgdGhhdCBoZSBnYXZlIGhpcyBvbmUgYW5kIG9ubHkgU29uLCB0aGF0IHdob2V2ZXIgYmVsaWV2ZXMgaW4gaGltIHNoYWxsIG5vdCBwZXJpc2ggYnV0IGhhdmUgZXRlcm5hbCBsaWZlLiAtIEpvaG4gMzoxNg== |
There was a problem hiding this comment.
I'm surprised this didn't trigger a warning that a secret was committed. I wonder if we can use something simpler here.
There was a problem hiding this comment.
I'm not sure if this repo has all the settings set like other repos.
I may be able to use something simpler, but I think I ran into issues if I did something too simple like abc123
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Changed
Removed
Note: Github Actions will fail if there are any env_files, even if they are part of a service that is not being used by Github Actions.