Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run in CI without using docker compose #59

Merged
merged 2 commits into from
Nov 8, 2024
Merged

run in CI without using docker compose #59

merged 2 commits into from
Nov 8, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Nov 7, 2024

No description provided.

@briskt briskt requested review from a team as code owners November 7, 2024 08:30
@briskt briskt requested review from forevermatt, jason-jackson, hobbitronics and Praveenraj-K and removed request for a team November 7, 2024 08:30
hobbitronics
hobbitronics approved these changes Nov 8, 2024
View reviewed changes
Copy link

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few questions to consider.

.github/workflows/ci.yml Show resolved Hide resolved
scripts/deploy.sh Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@briskt briskt merged commit 1aa0771 into main Nov 8, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobbitronics hobbitronics hobbitronics approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from silinternational/tf-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/tf-devs

@Praveenraj-K Praveenraj-K Awaiting requested review from Praveenraj-K Praveenraj-K is a code owner automatically assigned from silinternational/tf-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @hobbitronics