Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AWS version 5.X #56

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Use AWS version 5.X #56

merged 3 commits into from
Nov 6, 2024

Conversation

jason-jackson
Copy link
Contributor

Changed

  • Upgrade to AWS version 5.X

@jason-jackson jason-jackson requested review from a team, briskt, forevermatt and hobbitronics and removed request for a team October 11, 2024 21:15
@briskt
Copy link
Contributor

briskt commented Oct 12, 2024

The lock file should be updated using terraform init -upgrade. You can add the -backend=false flag to avoid interacting with the remote backend on HCP Terraform (Terraform Cloud).

@jason-jackson
Copy link
Contributor Author

The lock file should be updated using terraform init -upgrade. You can add the -backend=false flag to avoid interacting with the remote backend on HCP Terraform (Terraform Cloud).

I'll sync with you or Matt next week as I ran into issues with that.

briskt
briskt requested changes Oct 13, 2024
View reviewed changes
terraform/versions.tf Show resolved Hide resolved
@jason-jackson jason-jackson temporarily deployed to feature/upgrade-terraform-aws November 5, 2024 18:42 — with GitHub Actions Inactive
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jason-jackson jason-jackson requested a review from briskt November 5, 2024 18:43
briskt
briskt approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@briskt briskt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You could remove the version constraint if you want. I think I wasn't aware of that level of optimization when I first reviewed this PR.

@jason-jackson jason-jackson merged commit ab4e850 into develop Nov 6, 2024
2 checks passed
@jason-jackson jason-jackson deleted the feature/upgrade-terraform-aws branch November 6, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briskt briskt briskt approved these changes

@forevermatt forevermatt forevermatt approved these changes

@mtompset mtompset mtompset approved these changes

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics is a code owner automatically assigned from silinternational/tf-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jason-jackson @briskt @forevermatt @mtompset