Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intoto unmarshal #366

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Fix intoto unmarshal #366

merged 4 commits into from
Dec 20, 2024

Conversation

codysoyland
Copy link
Member

Summary

This PR is a modified copy of @gillisandrew's #326 with some slight simplifications. It is API-compatible with the existing codebase.

The attempt to upstream the fix for this is taking longer than expected, so this fix will serve as a temporary solution.

Fixes #365

Release Note

Documentation

@codysoyland codysoyland requested a review from a team as a code owner December 20, 2024 18:01
pkg/verify/signed_entity_test.go Show resolved Hide resolved
pkg/verify/signed_entity.go Outdated Show resolved Hide resolved
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creative solution with the alias!

@codysoyland codysoyland merged commit da38613 into main Dec 20, 2024
12 checks passed
@codysoyland codysoyland deleted the fix-intoto-unmarshal branch December 20, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON marshal of VerificationResult yields incorrectly-formatted in-toto attestation
4 participants