CF SDK - Implicit reattach #1110
Conversation
🦋 Changeset detectedLatest commit: 86abe0b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| let key = sessionStorage.key(i) | ||
|
|
||
| // If the key starts with "ci-" and is not the current key, remove it | ||
| if (key?.startsWith('ci-') && key !== callIdKey) { |
There was a problem hiding this comment.
Can we safely remove the other keys here?
What if the user is using a second tab to call another address, but then it needs to "reattach" on the first tab?
This is why, IMO, the SDK should not try to rule out whether the dial request should be a reattach or a plain dial. There are too many Application concerns to be considered.
There was a problem hiding this comment.
Regarding the second tab, we are using session storage, which means that two different tabs will have entirely separate storage. All these features work during one tab session.
I added this clear storage feature in my last few commits. The reasoning behind this was that after disconnecting from a call if the user joins a different call and then later rejoins the first call, we might not want to automatically reattach.
I have no strong objection to this feature, though; we can remove it so that the user is always reattached if they did not properly detach.
There was a problem hiding this comment.
It makes sense and, in this case, is safe.
However, I do question whether we should clean it, particularly if we're not taking into account the app use case.
I'm fine with both ways if the developer can change the behavior to match the app's needs.
| audio: params.audio ?? true, | ||
| video: params.audio ?? true, | ||
| negotiateAudio: params.negotiateAudio ?? true, | ||
| negotiateVideo: params.negotiateVideo ?? true, |
There was a problem hiding this comment.
Isn't this going to force video negotiation by default, even when the call is audio-only?
We need to consolidate the makeCallFabricObject default so we don't have to worry about changing or fixing it in 2 places.
Are most of the defaults distinct for inbound versus outbound?
There was a problem hiding this comment.
In an outbound call, we make this decision based on the to param which is the destination address. In the case of the inbound call, there is no to param exists.
Description
This PR will enable developers to integrate call reattachment without explicitly calling the "reattach" method. The "dial" method now tracks calls based on the destination address, and in cases where the call is not terminated correctly (e.g., due to a page reload, or the user pressing the browser back button), the "dial" method will automatically perform an implicit reattach without notifying the developer or user.
This is the default behavior which can be overridden by passing the optional flag
allowReattach: falseto the "dial" method.The explicit "reattach" method is still available for the developer to use.
Type of change
Code snippets