Auth.js OAuth 2.0 #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…client-beta into joao/use_auth_js # Conflicts: # env.example # index.js
|
We just need on implementation so let's discuss on this PR before merging it |
ryanwi
reviewed
Jan 10, 2024
| app.use('/api/auth/*', ExpressAuth(authConfig)) | ||
| app.use(authSession) | ||
|
|
||
| app.listen(process.env.PORT || 3000, () => { |
There was a problem hiding this comment.
this is where I get a little pedantic maybe, but I have not seen express app like this, started this way, is it the only way to import the esm or use the libs?
There was a problem hiding this comment.
currently and unfortunately, yes...
I agreed with that most existing code at this point don't feature that. But that is because this esm is getting more popular now. And there is a strong push for being the default.
But I guess we could also make our code an es module as better alternative
|
example app just added to auth.js nextauthjs/next-auth#9570 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the PKCE for OAuth 2.0 issue replacing the OAUTH client liv with Auth.js