Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nodejs from v2.15.0 to v3.0.0 in helm-charts/splunk-otel-collector/values.yaml #1609

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Use the latest version of nodejs

@github-actions github-actions bot requested review from a team as code owners January 11, 2025 01:09
@atoulme atoulme closed this Jan 11, 2025
@atoulme atoulme reopened this Jan 11, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2025
@github-actions github-actions bot force-pushed the update-nodejs branch 10 times, most recently from ab1da70 to 9d5c854 Compare January 13, 2025 12:57
@jvoravong jvoravong closed this Jan 13, 2025
@jvoravong jvoravong reopened this Jan 13, 2025
@github-actions github-actions bot force-pushed the update-nodejs branch 8 times, most recently from 92a9401 to 845be16 Compare January 15, 2025 12:55
@github-actions github-actions bot force-pushed the update-nodejs branch 2 times, most recently from 54dd04a to 59fcd29 Compare January 16, 2025 01:09
@github-actions github-actions bot force-pushed the update-nodejs branch 20 times, most recently from dbdbd5c to cce7336 Compare January 22, 2025 12:55
@jvoravong jvoravong closed this Jan 22, 2025
@jvoravong jvoravong reopened this Jan 22, 2025
@@ -1251,7 +1251,7 @@ instrumentation:
# value: java_value
nodejs:
repository: ghcr.io/signalfx/splunk-otel-js/splunk-otel-js
tag: v2.15.0
tag: v3.0.0
Copy link
Contributor

@jvoravong jvoravong Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both versions v2.16.0 and v3.0.0 were released. Asked around and it was recommended to migrate to use v3.0.0. To do this we have to link/add the breaking change notes and update our test golden file values.

@github-actions github-actions bot force-pushed the update-nodejs branch 5 times, most recently from 09c5ce2 to cada28f Compare January 24, 2025 01:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants