feat(shorebird_code_push): add download update functionality #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # shorebird_code_push/lib/src/shorebird_code_push.dart # shorebird_code_push/lib/src/updater.dart # shorebird_code_push/test/src/shorebird_code_push_test.dart # shorebird_code_push/test/src/updater_test.dart
felangel
reviewed
Jun 20, 2023
Comment on lines
+84
to
+85
| await _shorebirdCodePush.downloadUpdate(); | ||
| _nextPatchVersion = await _shorebirdCodePush.nextPatchNumber(); |
There was a problem hiding this comment.
Can these ever throw? Should they be wrapped in a try/catch?
There was a problem hiding this comment.
Can these ever throw?
Not as it stands. If the underlying ffi code throws, we catch those errors and log them.
felangel
reviewed
Jun 20, 2023
| } | ||
|
|
||
| /// Downloads the latest patch, if available. | ||
| Future<void> downloadUpdate() async { |
There was a problem hiding this comment.
Would be nice to return a Stream of progress updates eventually.
eseidel
reviewed
Jun 20, 2023
| @@ -2,48 +2,101 @@ import 'dart:isolate'; | |||
|
|
|||
| import 'package:shorebird_code_push/src/updater.dart'; | |||
|
|
|||
| /// A function that constructs an [Updater] instance. Used for testing. | |||
| typedef UpdaterBuilder = Updater Function(); | |||
There was a problem hiding this comment.
You can use @VisibleForTesting if you like, although that would add a package:meta dependency.
There was a problem hiding this comment.
We already had the meta dependency, so I did that and also made a forTest constructor so UpdaterBuilder isn't part of the public API.
eseidel
approved these changes
Jun 20, 2023
felangel
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for triggering patch download from a Flutter app.
Also adds logging for ffi errors to help point users in the correct direction when things aren't working as expected.
Type of Change