Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: record whether patches were forced, or contain asset/native code changes #1775

Merged
merged 6 commits into from
Mar 5, 2024

Conversation

bryanoltman
Copy link
Contributor

Description

When creating a patch, record whether the user used the --force flag and whether the patch contained asset or native code changes.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7b8ad14) to head (18d3423).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1775   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          167       167           
  Lines         5179      5191   +12     
=========================================
+ Hits          5179      5191   +12     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)
shorebird_code_push_client 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman marked this pull request as draft March 5, 2024 15:51
@bryanoltman
Copy link
Contributor Author

This currently updates the min Dart version for the CLI from 3.0.0 to 3.3.0. Moving to a draft while I diagnose.

@bryanoltman bryanoltman marked this pull request as ready for review March 5, 2024 16:02
@bryanoltman
Copy link
Contributor Author

Fixed, ready for review

@bryanoltman bryanoltman merged commit 2218d4a into main Mar 5, 2024
10 checks passed
@bryanoltman bryanoltman deleted the bo/patch-metadata branch March 5, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants