Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate that patch aar build-number matches the release build number #828

Closed
bryanoltman opened this issue Jul 11, 2023 · 4 comments
Closed

Comments

@bryanoltman
Copy link
Contributor

bryanoltman commented Jul 11, 2023

AARs do not have a release version – the release version is derived from the app that includes them. They are identified by build number (specified by the build-number option, which defaults to 1.0) – release version is only used by shorebird to associated an initial build of an AAR with patches.

It is currently possible to to do the following:

# release version 1.0.0
shorebird release aar --build-number=1.0

# still release version 1.0.0
shorebird patch aar --build-number=2.0
@eseidel
Copy link
Contributor

eseidel commented Aug 4, 2023

This is still an issue, but no longer as common since we've fixed our docs.

@pro100svitlo
Copy link

do you have plans to add support of --build-number=123 --build-name=2.0.2 to shorebird release command in the visible future?

@eseidel
Copy link
Contributor

eseidel commented Jun 12, 2024

My understanding is that our current thinking is we should implement shorebirdtech/samples#11 instead? Please re-open if I've misunderstood @bryanoltman

@eseidel eseidel closed this as completed Jun 12, 2024
@bryanoltman
Copy link
Contributor Author

Correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Customers
Development

No branches or pull requests

3 participants