Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android hybrid app does not detect new patch #1502

Closed
daniel-tan1 opened this issue Nov 16, 2023 · 5 comments
Closed

android hybrid app does not detect new patch #1502

daniel-tan1 opened this issue Nov 16, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@daniel-tan1
Copy link

I try to build a hybrid app according to the doc, but in the last step the app doesn't detect the new patch and nothing changes

shorebird doctor
Screenshot 2023-11-16 at 10 00 04
Screenshot 2023-11-16 at 10 01 58
Screenshot 2023-11-16 at 10 04 18

@daniel-tan1 daniel-tan1 added the bug Something isn't working label Nov 16, 2023
@eseidel eseidel added this to iOS Beta Nov 21, 2023
@eseidel eseidel moved this to Customers in iOS Beta Nov 21, 2023
@eseidel
Copy link
Contributor

eseidel commented Nov 21, 2023

"Thread finished with status: No update" would suggest that the updater code got a successful response from Shorebird's servers and the servers responded there was no update for the provided release version.

Do we know what release version this hybrid app is claiming to be? The patch was published against "1.2.3+1", but if the AndroidManifest.xml of the Hybrid app says something other than 1.2.3+1 it won't apply the patch.

#828 and #793 are also related here.

@bryanoltman
Copy link
Contributor

@TranVanDinh235 Can you share the release and patch commands you ran?

@bryanoltman bryanoltman moved this from Customers to Pending Customer Reply in iOS Beta Nov 21, 2023
@bryanoltman
Copy link
Contributor

I believe @eseidel is correct here in that the release version you specified when running shorebird release aar does not match what is in your build.grade (or pubspec.yaml, depending on where you define your version number) file. These need to be the same in order for shorebird to work.

@daniel-tan1
Copy link
Author

It looks like the published patch number is different from the hybrid app release number.
Screenshot 2023-11-27 at 15 07 07
Screenshot 2023-11-27 at 14 55 31

But whichever version I set, that hybrid app release number is always 1.0+2
Screenshot 2023-11-27 at 14 54 41
I tried refreshing gradle. Is this a problem?

@bryanoltman
Copy link
Contributor

The version code you provide to the shorebird command should match what is in your app/build.grade file. If https://docs.shorebird.dev/guides/hybrid-app/android#create-a-shorebird-release doesn't help, let us know!

@github-project-automation github-project-automation bot moved this from Pending Customer Reply to Done in iOS Beta Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants