Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add a section on patch performance #292

Merged
merged 6 commits into from
Sep 10, 2024
Merged
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/content/docs/code-push/patch.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -87,3 +87,21 @@ need to put `flutter build` arguments after a `--` separator. For example:
`shorebird patch android -- --dart-define="foo=bar"` will define the `"foo"` environment
variable inside Dart as you might have done with `flutter build` directly.
:::

### Patch Performance

Android: Patching an application on Android has no effect on performance.

iOS: Patching an application on iOS typically does not affect an application
performance. However the patching mechanism on iOS is different from Android.
eseidel marked this conversation as resolved.
Show resolved Hide resolved
Unchanged code runs as normal (on the CPU), changed (or added) code will run in
a Dart interpreter (slower than the CPU). Typically this change is
undetectable, but if you are changing particularly performance-sensitive Dart
code (e.g. code for processing images, or large data) you may see a performance
difference after patching.

You can always test your patches before sending them to users using by
[staging patches](/staging-patches).

If you ever see unexpected performance changes when patching, please [contact
us](mailto:[email protected]) we would love to help!
Loading