Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Releasing" to "Submitting" #281

Merged
merged 5 commits into from
Aug 8, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions astro.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,8 @@ export default defineConfig({
link: '/guides/code-push-quickstart',
},
{
label: 'Release',
autogenerate: {
directory: 'guides/release',
},
label: 'Crash Reporting',
link: '/guides/crash-reporting',
},
{
label: 'Staging Patches',
Expand All @@ -92,14 +90,16 @@ export default defineConfig({
},
},
{
label: 'Hybrid Apps',
label: 'Submitting to the Stores',
bryanoltman marked this conversation as resolved.
Show resolved Hide resolved
autogenerate: {
directory: 'guides/hybrid-apps',
directory: 'guides/submitting',
},
},
{
label: 'Crash Reporting',
link: '/guides/crash-reporting',
label: 'Hybrid Apps',
autogenerate: {
directory: 'guides/hybrid-apps',
},
},
],
},
Expand Down Expand Up @@ -182,5 +182,7 @@ export default defineConfig({
'guides/hybrid-app': 'guides/hybrid-apps/android',
'guides/hybrid-app/android': 'guides/hybrid-apps/android',
'guides/hybrid-app/ios': 'guides/hybrid-apps/ios',
'guides/release/android': 'guides/submitting/play-store',
'guides/release/ios': 'guides/submitting/app-store',
},
});
6 changes: 5 additions & 1 deletion src/content/docs/guides/flavors/android.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,11 @@ shorebird preview --app-id 904bd3d5-3526-4c1c-a832-7ac23c95302d --release-versio

This will download the releases and run them on your device.

In addition to previewing the releases locally, you should also [submit the generated app bundles to the Play Store](/guides/release/android#upload-to-the-play-store). In this case, both apps can be part of the internal test flavor and only the stable variant should be promoted to production.
In addition to previewing the releases locally, you should also [submit the
generated app bundles to the Play
Store](/guides/submitting/play-store#upload-to-the-play-store). In this case, both
apps can be part of the internal test flavor and only the stable variant should
be promoted to production.

:::note

Expand Down
6 changes: 5 additions & 1 deletion src/content/docs/guides/flavors/ios.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,11 @@ shorebird preview --app-id 904bd3d5-3526-4c1c-a832-7ac23c95302d --release-versio

This will download the releases and run them on your device.

In addition to previewing the releases locally, you should also [submit the generated app bundles to the App Store](/guides/release/ios#upload-to-the-app-store). In this case, both apps can be part of the internal test flavor and only the stable variant should be promoted to production.
In addition to previewing the releases locally, you should also [submit the
generated app bundles to the App
Store](/guides/submitting/app-store#upload-to-the-app-store). In this case, both apps can
be part of the internal test flavor and only the stable variant should be
promoted to production.

:::note

Expand Down
4 changes: 3 additions & 1 deletion src/content/docs/guides/staging-patches.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ shorebird release ios

We can verify the releases were created successfully by visiting [Shorebird console](https://console.shorebird.dev).

You should also [submit the generated app bundles to the Play Store](/guides/release/android#upload-to-the-play-store) and [submit the generated ipa to the App Store](/guides/release/ios#upload-to-the-app-store).
You should also [submit the generated app bundles to the Play
Store](/guides/submitting/play-store#upload-to-the-play-store) and [submit the
generated ipa to the App Store](/guides/submitting/app-store#upload-to-the-app-store).

## Creating a patch

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
title: Releasing to the Apple App Store
description: Release a Code Push App to the Apple App Store
sidebar:
label: iOS
label: App Store
order: 2
---

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
title: Releasing to the Google Play Store
description: Release a Code Push App to the Google Play Store
sidebar:
label: Android
label: Play Store
order: 1
---

Expand Down
10 changes: 5 additions & 5 deletions src/content/docs/troubleshooting.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ Patches are only compatible with the release version they were created for. If
you create a patch for version `1.0.0+1`, it will not work on version `1.0.0+2`.

:::note
This can happen unexpectedly on iOS due to Xcode's automatic incrementing of
build numbers. If you are seeing this issue on iOS, ensure that the build number
of the release and the patch match. See [our iOS releasing
guide](/guides/release/ios/#upload-to-the-app-store) for instructions on how to
disable automatic build number incrementing.
This can happen unexpectedly on iOS due to Xcode's automatic
incrementing of build numbers. If you are seeing this issue on iOS, ensure that
the build number of the release and the patch match. See [our iOS releasing
guide](/guides/submitting/app-store/#upload-to-the-app-store) for instructions
on how to disable automatic build number incrementing.
:::

#### How to tell if this is the problem
Expand Down