Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fastlane guide to reflect plugin update #275

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Update fastlane guide to reflect plugin update #275

merged 1 commit into from
Jul 30, 2024

Conversation

bryanoltman
Copy link
Contributor

Our new version of the fastlane plugin autodetects the ipa path, so it is no longer necessary to explicitly pass this value.

@bryanoltman bryanoltman requested review from eseidel and felangel July 30, 2024 18:47
@eseidel
Copy link
Contributor

eseidel commented Jul 30, 2024

I presume our plugin still (optionally) takes an ipa parameter to not break existing users?

@bryanoltman
Copy link
Contributor Author

I presume our plugin still (optionally) takes an ipa parameter to not break existing users?

upload_to_testflight isn't ours. The update has our plugin pass the IPA path via an env variable instead of making the user specify it.

@bryanoltman bryanoltman merged commit 10e2323 into main Jul 30, 2024
3 checks passed
@bryanoltman bryanoltman deleted the bo/fastlane-update branch July 30, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eseidel eseidel eseidel approved these changes

@felangel felangel Awaiting requested review from felangel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanoltman @eseidel