Improve email field #449
Merged
Improve email field #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Haberkamp
force-pushed
the
rewrite-email-field
branch
from
53d0a42 to
53f0f33
Compare
Haberkamp
force-pushed
the
rewrite-email-field
branch
from
53f0f33 to
4a54c34
Compare
Haberkamp
force-pushed
the
rewrite-email-field
branch
from
77488f4 to
18700d3
Compare
Haberkamp
force-pushed
the
rewrite-email-field
branch
from
806c68c to
47f2e89
Compare
…email field is unlinked
Haberkamp
force-pushed
the
rewrite-email-field
branch
from
f74d7fc to
79746e4
Compare
alastair-simon
approved these changes
Feb 5, 2025
Lucsy3012
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR refactors the email field
Why?
The email input was coupled to many other components. This change reduces the coupling to other components.
How?
I've written many tests before refactoring the component and then did a refactor
Testing?
I've written more than 25 tests to make sure everything works the same as before