[16.0][FIX] shopinvader_anonymous_partner: auth cookie reseted #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when reseting shopinvader-anonymous-partner cookie, a new set-cookie option is set inside the response. However, it seems that only the last operation is received by the client so the auth cookie is lost. As the operation cookie has already been set earlier, we can avoid reseting shopinvader-anonymous-partner-cookie
sbidoul
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reseting shopinvader-anonymous-partner cookie, a new set-cookie option is set inside the headers of the response. However, it seems that only the last operation is received by the client so the auth cookie is lost so the user is no longer authentiticated for the next operation. As the auth cookie has already been set earlier, we can avoid reseting shopinvader-anonymous-partner-cookie.
This can be tested simply by setting a cookie at the end of the /signin operation from a jwt token.
I think this PR should not be merged as this might not be the right fix.
cc @lmignon