Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] shopinvader track_external_mixin #1560

Open
wants to merge 2 commits into
base: 14.0
Choose a base branch
from

Conversation

acsonefho
Copy link
Contributor

  • [FIX] During the creation of a record who inherit track.external.mixin, the last_external_update_date field was not set.

  • [IMP] Improve the job who is cleaning those carts by adding an identity_key. That could avoid overloading queue job if something (not related to shopinvader) flood it.

  • auto-update of index.html (has been done automatically)

@acsonefho acsonefho force-pushed the 14.0-fix_shopinvader_track_external_mixin branch from 6eed2de to f4c86fb Compare June 11, 2024 13:02
During the creation of a model who inherites of track;external.mixin, the last_external_update_date was not set (with current datetime)
Improve the job in charge of unlink old carts by adding an identity key (to avoid having too much jobs who are doing the same cleaning on the same backend)
@acsonefho acsonefho force-pushed the 14.0-fix_shopinvader_track_external_mixin branch from f4c86fb to fe7bc00 Compare June 11, 2024 13:07
Copy link
Contributor

@xavier-bouquiaux xavier-bouquiaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastienbeau sebastienbeau added this to the 14.0 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants