Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] shopinvader_search_engine_product_stock: Migration to 16.0 #1431

Merged
merged 5 commits into from
Nov 2, 2023
Merged

[16.0][MIG] shopinvader_search_engine_product_stock: Migration to 16.0 #1431

merged 5 commits into from
Nov 2, 2023

Conversation

qgroulard
Copy link
Contributor

@qgroulard qgroulard commented Oct 19, 2023 •
edited by lmignon
Loading

lmignon
lmignon requested changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qgroulard Good job. Some little comments...

shopinvader_search_engine_product_stock/models/product_product.py Outdated Show resolved Hide resolved
shopinvader_search_engine_product_stock/models/product_product.py Outdated Show resolved Hide resolved
shopinvader_search_engine_product_stock/models/se_index.py Outdated Show resolved Hide resolved
shopinvader_search_engine_product_stock/models/se_index.py Show resolved Hide resolved
@qgroulard qgroulard force-pushed the 16.0-mig-shopinvader_product_stock-qgr branch from f76fce3 to 22b15ec Compare October 26, 2023 13:24
@lmignon
Copy link
Collaborator

lmignon commented Nov 2, 2023

/ocabot merge nobump

@shopinvader-git-bot
Copy link

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1431-by-lmignon-bump-nobump, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Nov 2, 2023
Merge PR #1431 into 16.0
8e8a4d5 
Signed-off-by lmignon
@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@shopinvader-git-bot
Copy link

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-1431-by-lmignon-bump-nobump, awaiting test results.

@lmignon
Copy link
Collaborator

lmignon commented Nov 2, 2023

/ocabot merge nobump

@shopinvader-git-bot shopinvader-git-bot merged commit 0314103 into shopinvader:16.0 Nov 2, 2023
3 checks passed
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 36179f0. Thanks a lot for contributing to shopinvader. ❤️

@shopinvader-git-bot
Copy link

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1431-by-lmignon-bump-nobump, awaiting test results.

@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 36179f0. Thanks a lot for contributing to shopinvader. ❤️

@lmignon lmignon deleted the 16.0-mig-shopinvader_product_stock-qgr branch November 2, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbejaoui sbejaoui sbejaoui approved these changes

@lmignon lmignon lmignon approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qgroulard @lmignon @shopinvader-git-bot @sbejaoui