[16.0] [MIG] shopinvader_sale_packaging #1400
Conversation
This reverts commit 1e05d73.
We used to have a 'variant_count' field related to 'product_variant_count'. I don't think this is necessary anymore, we can refer to 'product_variant_count' in the schema.
marielejeune
force-pushed
the
16.0-mig-shopinvader_sale_packaging
branch
2 times, most recently
from
9044b08 to
a6e7983
Compare
| # consider only packaging that can be displayed | ||
| "_packaging_filter": lambda x: x.shopinvader_display, | ||
| "_packaging_values_handler": self._prepare_qty_by_packaging_values, | ||
| } | ||
|
|
||
| def _prepare_qty_by_packaging_values(self, packaging, qty_per_pkg): | ||
| # TODO: why re-define? Duplicate of stock_packaging_calculator/models/product.py L147 |
There was a problem hiding this comment.
Not sure to understand why this method is redefined here as it is a duplicate of stock_packaging_calculator/models/product.py (L147), already in v14.
marielejeune
force-pushed
the
16.0-mig-shopinvader_sale_packaging
branch
from
a6e7983 to
d8e63e4
Compare
| return { | ||
| "lang": self.lang_id.code, |
There was a problem hiding this comment.
How to deal with user lang now that we don't have it from the backend anymore?
|
In |
marielejeune
force-pushed
the
16.0-mig-shopinvader_sale_packaging
branch
2 times, most recently
from
e024319 to
d85a170
Compare
…e_packaging and shopinvader_restapi_sale_packaging
marielejeune
force-pushed
the
16.0-mig-shopinvader_sale_packaging
branch
from
d85a170 to
5784676
Compare
| /> | ||
| <field name="arch" type="xml"> | ||
| <field name="force_sale_qty" position="after"> | ||
| <!-- TODO: group on this field was shopinvader.group_shopinvader_manager--> | ||
| <field name="shopinvader_display" /> |
There was a problem hiding this comment.
Both fields added in this view were restricted to shopinvader.group_shopinvader_manager group. Now this group moved to shopinvader_restapi, but our addon shouldn't depend on shopinvader_restapi just for a security group...
shopinvader_product_sale_packagingto add packaging info into search engine schemasshopinvader_restapi_sale_packagingto allow rest services to purchase products by packaging.product.packaging.typewas renamedproduct.packaging.level. Adapt all the references.Depends on
sell_only_by_packaging: [16.0][MOV] sale_by_packaging becomes sell_only_by_packaging OCA/sale-workflow#2623product_packaging_level: [MIG][16.0] product_packaging_type + renaming to product_packaging_level OCA/product-attribute#1215product_packaging_level_salable: [16.0][ADD] product_packaging_level_salable OCA/product-attribute#1395stock_packaging_calculator_packaging_level: [16.0][MIG] stock_packaging_calculator_packaging_type + rename stock_packaging_calculator_packaging_level OCA/stock-logistics-warehouse#1816-> Not ready yet, no change since a few weeks. Must be done again?
TODO