Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest Support the OPUS format for Enhanced RTMP. #1674

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

shogo4405
Copy link
Owner

@shogo4405 shogo4405 commented Jan 25, 2025

Description & motivation

Support for the OPUS extension in Enhanced RTMP. This PR is for Ingest only. I’d like to implement Playback as well, but I can’t find a product with server-side support. Could someone help?

Usage

var audioSettings = AudioCodecSettings()
audioSettings.format = .opus
await stream.setAudioSettings(audioSettings)
  • I tests using mediamtx.
    • Ingest H264 + Opus
    • There seems to be some audio dropouts, but it's unclear whether the issue lies with HaishinKit or some other factor.
ffplay http://localhost:8888/live/live/index.m3u8

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots:

@shogo4405 shogo4405 marked this pull request as draft January 25, 2025 08:34
Copy link

Danger has errored

[!] Invalid Dangerfile file: No such file or directory @ rb_sysopen - HaishinKit/Tests/RTMP/FLVVideoFourCCTests.swift

 #  from Dangerfile:3
 #  -------------------------------------------
 #  
 >  privacymanifest.report
 #  -------------------------------------------

Generated by 🚫 Danger

@shogo4405 shogo4405 changed the title Support the OPUS format for Enhanced RTMP. Support the Ingest OPUS format for Enhanced RTMP. Jan 25, 2025
@shogo4405 shogo4405 changed the title Support the Ingest OPUS format for Enhanced RTMP. Ingest Support the OPUS format for Enhanced RTMP. Jan 25, 2025
@shogo4405 shogo4405 force-pushed the feature/rtmp-enhanced-audio branch 3 times, most recently from baf307a to b19d65d Compare January 26, 2025 08:54
@shogo4405 shogo4405 force-pushed the feature/rtmp-enhanced-audio branch from b19d65d to 0bfc2e3 Compare January 27, 2025 11:33
@shogo4405 shogo4405 marked this pull request as ready for review January 27, 2025 11:35
@shogo4405 shogo4405 merged commit 9fe54b1 into main Jan 27, 2025
2 checks passed
@shogo4405 shogo4405 deleted the feature/rtmp-enhanced-audio branch January 27, 2025 11:51
@shogo4405 shogo4405 added this to the 2.0.4 milestone Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant