Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build action #362

Merged
merged 8 commits into from
Jan 19, 2025
Merged

fix build action #362

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b0caddb
actions
shocknet-justin Jan 19, 2025
48bc7ae
actions test
shocknet-justin Jan 19, 2025
4c2c72a
actions ls
shocknet-justin Jan 19, 2025
133c489
actions ls
shocknet-justin Jan 19, 2025
7d69a88
actions
shocknet-justin Jan 19, 2025
ba10aa6
actions 34
shocknet-justin Jan 19, 2025
75f2903
actions
shocknet-justin Jan 19, 2025
9639cce
actions
shocknet-justin Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 24 additions & 11 deletions .github/workflows/android-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,17 @@ jobs:
node-version: '20'
cache: 'npm'

- name: Set up Android SDK
uses: android-actions/setup-android@v3
with:
accept-android-sdk-licenses: true

- name: Install Android SDK packages
run: |
echo "y" | sdkmanager --licenses > /dev/null 2>&1 || true
sdkmanager "build-tools;34.0.0" "platforms;android-33"
shell: bash

- name: Install deps
run: |
npm ci
Expand Down Expand Up @@ -134,13 +145,9 @@ jobs:
echo "AndroidManifest.xml contents after Gradle build:"
cat android/app/src/main/AndroidManifest.xml

- name: Set up Android SDK
uses: android-actions/setup-android@v3
with:
accept-android-sdk-licenses: true
packages: |
build-tools;33.0.0
platforms;android-33
- name: List available Android SDK packages
run: |
$ANDROID_SDK_ROOT/cmdline-tools/latest/bin/sdkmanager --list || $ANDROID_HOME/cmdline-tools/latest/bin/sdkmanager --list

- name: Decode Keystore
run: |
Expand All @@ -154,12 +161,12 @@ jobs:

- name: Sign APK
run: |
$ANDROID_SDK_ROOT/build-tools/33.0.0/apksigner sign --ks my-release-key.keystore --ks-pass pass:${{ secrets.ANDROID_KEYSTORE_PASSWORD }} --key-pass pass:${{ secrets.ANDROID_KEY_PASSWORD }} --out android/app/build/outputs/apk/release/${{ env.VITE_APP_NAME }}-${{ env.VERSION }}.apk android/app/build/outputs/apk/release/app-release-unsigned.apk
$ANDROID_SDK_ROOT/build-tools/34.0.0/apksigner sign --ks my-release-key.keystore --ks-pass pass:${{ secrets.ANDROID_KEYSTORE_PASSWORD }} --key-pass pass:${{ secrets.ANDROID_KEY_PASSWORD }} --out android/app/build/outputs/apk/release/${{ env.VITE_APP_NAME }}-${{ env.VERSION }}.apk android/app/build/outputs/apk/release/app-release-unsigned.apk
shell: bash

- name: Verify APK
run: |
$ANDROID_SDK_ROOT/build-tools/33.0.0/apksigner verify android/app/build/outputs/apk/release/${{ env.VITE_APP_NAME }}-${{ env.VERSION }}.apk
$ANDROID_SDK_ROOT/build-tools/34.0.0/apksigner verify android/app/build/outputs/apk/release/${{ env.VITE_APP_NAME }}-${{ env.VERSION }}.apk
shell: bash

- name: Upload APK to GitHub Release
Expand Down Expand Up @@ -203,7 +210,7 @@ jobs:
echo "AndroidManifest.xml contents:"
if unzip -p "$APK_FILE" AndroidManifest.xml > manifest.xml; then
if [ -s manifest.xml ]; then
$ANDROID_SDK_ROOT/build-tools/33.0.0/aapt dump xmltree manifest.xml || echo "aapt command failed"
$ANDROID_SDK_ROOT/build-tools/34.0.0/aapt dump xmltree manifest.xml || echo "aapt command failed"
else
echo "Extracted AndroidManifest.xml is empty"
fi
Expand All @@ -217,4 +224,10 @@ jobs:

- name: Check aapt version
run: |
$ANDROID_SDK_ROOT/build-tools/33.0.0/aapt version || echo "aapt not found or failed to run"
$ANDROID_SDK_ROOT/build-tools/34.0.0/aapt version || echo "aapt not found or failed to run"

- name: Find sdkmanager location
run: |
echo "ANDROID_SDK_ROOT: $ANDROID_SDK_ROOT"
echo "ANDROID_HOME: $ANDROID_HOME"
ls -R $ANDROID_SDK_ROOT || ls -R $ANDROID_HOME
Loading