Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: implemented useNavigate hook at required loactions #90

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

sksmagr23
Copy link
Contributor

@sksmagr23 sksmagr23 commented Jun 11, 2024

Description

I have used useNavigate hook in place of window.
location.href for better web performance,
wherever required

fixes: #89

How to Test

  • run "npm run dev"
  • navigate different pages

Related Issues

Checklist

  • I have tested these changes locally.
  • I have reviewed the code and ensured it follows the project's coding guidelines.
  • I have updated the documentation, if necessary.
  • I have assigned reviewers to this pull request.

Screenshots (if applicable)

I have used useNavigate hook in place of window.
location.href for better web performance,
wherever required

fixes: shivansh-bhatnagar18#89
Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
multiplayer-uno ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 11:19am

@kuv2707
Copy link
Collaborator

kuv2707 commented Jun 11, 2024

I'd suggest you to keep the commit messages in passive voice. The "I did/ I changed" doesn't make much sense when one goes through the commit history.

@kuv2707 kuv2707 merged commit d0f7164 into shivansh-bhatnagar18:master Jun 11, 2024
8 checks passed
@sksmagr23
Copy link
Contributor Author

Ok, i will take care now onwards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

frontend: Use useNavigate hook for programmatically navigating between pages.
2 participants