Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: JoinExistingGame Modal implementation #86

Merged

Conversation

asmit27rai
Copy link
Contributor

JoinExistingGame Modal Implementation

Fixes #84

Description

  • JoinExistingGame modal component created to capture room code for game entry.
  • onClose function utilized for modal closure by tapping anywhere on the screen.
  • Navigation to the /game route triggered by pressing the Enter button after input entry; otherwise, a toast prompts for input completion.

How to Test

Click On Start Game Button To See The Modal.

Checklist

  • I have tested these changes locally.
  • I have reviewed the code and ensured it follows the project's coding guidelines.
  • I have updated the documentation, if necessary.
  • I have assigned reviewers to this pull request.

Screenshots (if applicable)

Screenshot 2024-06-09 233457

Screenshot 2024-06-09 233509

Copy link

vercel bot commented Jun 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
multiplayer-uno ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 7:23am

@shivansh-bhatnagar18
Copy link
Owner

@asmit27rai The design of the modal looks good but please try using tailwind for styling

@kuv2707
Copy link
Collaborator

kuv2707 commented Jun 12, 2024

@asmit27rai Please remove unrelated (backend) changes from the PR.

JoinExistingGame modal component created to capture room code for game entry.

onClose function utilized for modal closure by tapping anywhere on the screen.

Navigation to the /game route triggered by pressing the Enter button after input entry; otherwise,a toast prompts for input completion.

Fixes shivansh-bhatnagar18#84
@asmit27rai
Copy link
Contributor Author

@asmit27rai Please remove unrelated (backend) changes from the PR.

Done..

@shivansh-bhatnagar18 shivansh-bhatnagar18 merged commit 0bdacb7 into shivansh-bhatnagar18:master Jun 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the JoinExistingGame Component
4 participants