Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: designed a custom button component based on figma design #83

Merged

Conversation

sksmagr23
Copy link
Contributor

Description

I have created a customizable and reusable button based on the given figma design, in src/library.
I have used all possible input props and styled using tailwind css and added some custom pluggins and css as required.

Fixes: #76

Related Issues

Checklist

  • I have tested these changes locally.
  • I have reviewed the code and ensured it follows the project's coding guidelines.
  • I have updated the documentation, if necessary.
  • I have assigned reviewers to this pull request.

Screenshots

Screenshot from 2024-06-08 09-38-48

Copy link

vercel bot commented Jun 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
multiplayer-uno ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2024 7:48am

@sksmagr23
Copy link
Contributor Author

@shivansh-bhatnagar18 please review and merge these changes, so that other components can be made

@kuv2707
Copy link
Collaborator

kuv2707 commented Jun 8, 2024

@sksmagr23 Please rebase you branch once.
It can be merged then.

I have created a customizable and reusable button
based on the given figma design, in src/library.
I have used all possible input props and styled
using tailwind css and added some custom pluggins
and css as required.

Fixes: shivansh-bhatnagar18#76
@sksmagr23
Copy link
Contributor Author

sksmagr23 commented Jun 8, 2024

Done rebasing with upstream @kuv2707

@kuv2707
Copy link
Collaborator

kuv2707 commented Jun 8, 2024

@shivansh-bhatnagar18 Please have a look.

@shivansh-bhatnagar18
Copy link
Owner

@sksmagr23 Thanks for the PR. The button component looks great

@shivansh-bhatnagar18 shivansh-bhatnagar18 merged commit 0df72f8 into shivansh-bhatnagar18:master Jun 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design a button component
3 participants