Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: Added a customizable and reusable heading component #75

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

sksmagr23
Copy link
Contributor

@sksmagr23 sksmagr23 commented Jun 7, 2024

Description

I have created a highly customizable and reusable header component in src/library, and the styling is done using tailwind css and added various input fields as props.

I have also modified and updated my previously created playoptions page(which is merged) with this heading component. This heading component has various props which you can see in attached screenshot.

Fixes: #67

How to Test

  • Run 'npm run dev' under frontend directory
  • Navigate to /play and you can see use of customizable header component

Related Issues

Checklist

  • I have tested these changes locally.
  • I have reviewed the code and ensured it follows the project's coding guidelines.
  • I have updated the documentation, if necessary.
  • I have assigned reviewers to this pull request.

Screenshots

Screenshot from 2024-06-07 11-23-06 Screenshot from 2024-06-07 12-44-11

Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
multiplayer-uno ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 9:13am

@kuv2707
Copy link
Collaborator

kuv2707 commented Jun 7, 2024

Please update the PR description to contain the clause Fixes: #issueno since that is what's used by github to associate the issue with the PR

@kuv2707
Copy link
Collaborator

kuv2707 commented Jun 7, 2024

Also, please add screenshots of dummy headings created using this component, demonstrating various configurations

@sksmagr23
Copy link
Contributor Author

updated the description and added screenshot of dummy headings

@kuv2707
Copy link
Collaborator

kuv2707 commented Jun 7, 2024

Looks great!

@kuv2707
Copy link
Collaborator

kuv2707 commented Jun 7, 2024

Please amend the fixes clause in the commit message just like the description.
Also restrict around 72 characters per line in the message.

You'd just need to run git commit --amend and insert line breaks as appropriate.
Save the changes and exit, then run git push --force

It can be merged once these changes are made.

I have created a highly customizable and reusable
header component in src/library, and the styling is done using tailwind
css and added various input fields as props.

Fixes: shivansh-bhatnagar18#67
@sksmagr23
Copy link
Contributor Author

@kuv2707 I have done the changes

@kuv2707 kuv2707 merged commit 3c7dc8c into shivansh-bhatnagar18:master Jun 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design customizable Heading component.
2 participants