Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: Added a Playoptions page #65

Merged

Conversation

sksmagr23
Copy link
Contributor

@sksmagr23 sksmagr23 commented Jun 4, 2024

Description

This commit add a playoptions page that renders onn navigating to /play. It has been created using Heading and button components of library and custom styling is done using Tailwind css and also added a UNO game logo, the page is fully responsive with a uno theme design

How to Test

-Run npm run dev under frontend directory, and navigate to /play

Related Issues

-fix/issue #23

Checklist

  • I have tested these changes locally.
  • I have reviewed the code and ensured it follows the project's coding guidelines.
  • I have updated the documentation, if necessary.
  • I have assigned reviewers to this pull request.

Screenshots

Screenshot from 2024-06-04 15-08-40

This commit add a playoptions page that renders onn navigating to /play.
It has been created using Heading and button components of library and
custom styling is done using Tailwind css and also added a UNO game logo,
the page is fully responsive with a uno theme design

Fixes-shivansh-bhatnagar18#23
Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
multiplayer-uno ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 10:17am

@sksmagr23
Copy link
Contributor Author

@kuv2707 and @shivansh-bhatnagar18 please review,this time I have well addressed the commits and checks

@ApoorvDubey23
Copy link
Collaborator

This will be merged after the creation of Heading and button component i.e. after #67 and #20 are done .Make sure to integrate both of the components in your code afterwards.

@shivansh-bhatnagar18
Copy link
Owner

Thanks @sksmagr23 for the pull request. I am merging it for now on but this needs a lot of refinement.

@shivansh-bhatnagar18 shivansh-bhatnagar18 merged commit 19abe9b into shivansh-bhatnagar18:master Jun 6, 2024
8 checks passed
@kuv2707
Copy link
Collaborator

kuv2707 commented Jun 6, 2024

@sksmagr23 Please be motivated to refactor this area of code with library components as they are added.

They can be done through future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants