client:Implemented the enqueuing mechanism for clients #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuv2707
reviewed
Jun 4, 2024
backend/eventRecipients.ts
Outdated
| @@ -31,9 +31,19 @@ export function getClient(clientId: ClientId) { | |||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | |||
| export function scheduleSend(clientId: ClientId, event: AppEvent) { | |||
| //todo: Enqueue the event for sending. | |||
| eventQueue.get(clientId)?.push(event); | |||
| } | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | |||
| export function doSendEvent(clientId: ClientId) { | |||
There was a problem hiding this comment.
This is not a part of this PR.
kuv2707
reviewed
Jun 4, 2024
backend/eventRecipients.ts
Outdated
| @@ -31,9 +31,19 @@ export function getClient(clientId: ClientId) { | |||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | |||
| export function scheduleSend(clientId: ClientId, event: AppEvent) { | |||
| //todo: Enqueue the event for sending. | |||
| eventQueue.get(clientId)?.push(event); | |||
There was a problem hiding this comment.
You can remove the todo comment and the eslint directive
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@kuv2707 done with the changes |
|
@kuv2707 edited the commit message. |
|
@ritwik-69 This can be merged once the merge conflicts are resolved. |
kuv2707
force-pushed
the
master
branch
3 times, most recently
from
4dd6ce4 to
7bc3d56
Compare
This commits creates a function that pushes the event object into the event queue of a specific client id. Fixes:shivansh-bhatnagar18#60
|
Merged, thanks @ritwik-69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #60
Description
Created two functions that pushes the event object into the event queue of a specific client id.
The second Function sends the each event of the given client id to all the eligible client id (i.e only if response object is available).
Motivation and Context
[Explain the motivation behind these changes and provide any relevant context.]
How to Test
[Describe the steps to test the changes made in this pull request.]
Related Issues
[If applicable, mention any related issues or pull requests.]
Checklist
Screenshots (if applicable)
[If your changes include any visual updates, provide screenshots here.]