Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server: Implement doSendEvents Fun #63

Merged
merged 1 commit into from
Jun 7, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions backend/src/eventRecipients.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,13 @@ export function scheduleSend(clientId: ClientId, event: AppEvent) {
//todo: Enqueue the event for sending.
}

// eslint-disable-next-line @typescript-eslint/no-unused-vars
export function doSendEvent(clientId: ClientId) {
//todo: Send all the events in the queue to the client, only if the response object is available.
export function doSendEvents(clientId: ClientId) {
const res = clients.get(clientId);
const events = eventQueue.get(clientId) || [];

if (res && events.length > 0) {
res.json({ events });
eventQueue.set(clientId, []);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also remove the clientId from clients since the current res object cannot be used further.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also remove the clientId from clients since the current res object cannot be used further.

Done

clients.delete(clientId);
}
}
Loading