-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ErrorPage: created 404 Page Not Found page #59
Merged
shivansh-bhatnagar18
merged 1 commit into
shivansh-bhatnagar18:master
from
sethdivyansh:fix/issue-#21
Jun 6, 2024
Merged
ErrorPage: created 404 Page Not Found page #59
shivansh-bhatnagar18
merged 1 commit into
shivansh-bhatnagar18:master
from
sethdivyansh:fix/issue-#21
Jun 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Awesome design! |
sethdivyansh
force-pushed
the
fix/issue-#21
branch
from
June 3, 2024 08:18
e7c624a
to
d09be73
Compare
sethdivyansh
force-pushed
the
fix/issue-#21
branch
from
June 3, 2024 08:51
d09be73
to
0449764
Compare
ApoorvDubey23
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Design
LGTM. Please fix the prettier issues otherwise its really good |
This commit adds a UNO theme 404 page not found page. Ensured the page is fully responsive for various devices. Included Page not Found error message and navigation link back to the homepage. Fixes:shivansh-bhatnagar18#21
sethdivyansh
force-pushed
the
fix/issue-#21
branch
from
June 4, 2024 18:46
0449764
to
d25bb48
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@shivansh-bhatnagar18 I have resolved the prettier issue. |
shivansh-bhatnagar18
merged commit Jun 6, 2024
9360849
into
shivansh-bhatnagar18:master
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #21
Description
This commit adds a UNO theme 404 page not found page.
Ensured the page is fully responsive for various devices.
Included Page not Found error message and navigation link back to the homepage.
How to Test
Start the frontend and go to any page that does not exists.
Checklist
Screenshots (if applicable)
On hover:
small screen devices