Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made an error page #55

Closed
wants to merge 1 commit into from
Closed

Made an error page #55

wants to merge 1 commit into from

Conversation

asmb123
Copy link

@asmb123 asmb123 commented Jun 2, 2024

Description

Added an Error page.
Fixes #21

Motivation and Context

Error page renders if an unknown route is accessed.

How to Test

  1. Use the command npm run dev in the console and open the application.
  2. In the search box add "/k" (or any other route which is not recognized by the router) after the existing text.

Related Issues

[If applicable, mention any related issues or pull requests.]

Checklist

  • I have tested these changes locally.
  • I have reviewed the code and ensured it follows the project's coding guidelines.
  • I have updated the documentation, if necessary.
  • I have assigned reviewers to this pull request.

Screenshots

ss

@shivansh-bhatnagar18
Copy link
Owner

Thank you @asmb123 for your Pull Request. Every Pull request matters but we have found out a better Error page for the same. For now I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design an error page
2 participants