Created the Button component #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ritwik-69 Please attach some screenshots demonstrating the various options. |
kuv2707
added
area: Frontend (structure)
|
kuv2707
reviewed
Jun 1, 2024
frontend/src/library/button.tsx
Outdated
|
|
||
|
|
||
|
|
||
| function Button({ children, onClick,size="medium",bgColor="bg-blue-500",textColor="text-white",borderColor="border-red-500",shape }: ButtonProps) { |
There was a problem hiding this comment.
Make the default value of borderColor the textColor, so that it takes the textColor when borderColor isn't passed.
kuv2707
reviewed
Jun 1, 2024
frontend/src/library/button.tsx
Outdated
| textColor?: string; | ||
| bgColor?: string; | ||
| borderColor?: string; | ||
| shape?:'rectangle' | 'rounded' | 'circle'; |
There was a problem hiding this comment.
You can change "circle" to "pill".
We probably won't need circular buttons anyway.
This commit creates a button component which is reusable and customizable like mentioned in the issue Note:Things like hover effect,focus etc. has still not been implemented as it was not mentioned in the issue Update:updated circles as pills and gave borderColor default value of textColor fixes:shivansh-bhatnagar18#20
|
@kuv2707 done with the changes |
|
@shivansh-bhatnagar18 design.. |
|
@ritwik-69 Closing as it is assigned to someone else after the design discussions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes:#20
Description
Created a button component which is reusable and customizable like mentioned in issue
Checklist
Screenshots (if applicable)
[If your changes include any visual updates, provide screenshots here.]
Example 1: syntax with a sample onClick function.
Result
Example 2:
result