deck: Implemented Fisher-Yates shuffling algorithm to shuffle the deck #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
sethdivyansh
force-pushed
the
fix/issue-#2
branch
from
2e3e179 to
4e7c032
Compare
|
@sethdivyansh Please resolve merge conflicts. |
sethdivyansh
force-pushed
the
fix/issue-#2
branch
from
4e7c032 to
df497a0
Compare
|
@kuv2707 i have resolved the conflicted. |
|
I suggest you write a test for this in deck.test.ts Its not exactly required, but it would give you a chance to write unit tests for your logic. We use the 'jest' library for testing. The test should be in the same commit. |
sethdivyansh
force-pushed
the
fix/issue-#2
branch
from
df497a0 to
1c1b883
Compare
|
@kuv2707 i have added the shuffle deck test in deck.test.ts |
sethdivyansh
force-pushed
the
fix/issue-#2
branch
from
1c1b883 to
721eeb9
Compare
kuv2707
approved these changes
Jun 2, 2024
| const orderChanged = deck.some( | ||
| (card, index) => card !== originalDeck[index] | ||
| ); | ||
| expect(orderChanged).toBe(true); |
There was a problem hiding this comment.
Great work detecting order change!
|
Merged, thanks @sethdivyansh ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2
Description
Shuffled the deck using Fiesher-Yates algorithm
Checklist