Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deck: completed function to create and shuffle a UNO card deck. #29

Closed
wants to merge 1 commit into from
Closed

deck: completed function to create and shuffle a UNO card deck. #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions backend/uno-game-engine/deck.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const colors: Array<CardColor> = ['red', 'yellow', 'green', 'blue'];

Check failure on line 1 in backend/uno-game-engine/deck.ts

View workflow job for this annotation

GitHub Actions / eslint-backend 

'colors' is assigned a value but never used
const values = [

Check failure on line 2 in backend/uno-game-engine/deck.ts

View workflow job for this annotation

GitHub Actions / eslint-backend 

'values' is assigned a value but never used
'0',
'1',
'2',
Expand All @@ -14,8 +14,8 @@
'reverse',
'draw2',
];
const specialCards = ['wild', 'draw4'];

Check failure on line 17 in backend/uno-game-engine/deck.ts

View workflow job for this annotation

GitHub Actions / eslint-backend 

'specialCards' is assigned a value but never used
const deck = [];

Check failure on line 18 in backend/uno-game-engine/deck.ts

View workflow job for this annotation

GitHub Actions / eslint-backend 

'deck' is assigned a value but never used

/**
* In a standard UNO deck, there are 108 cards. Here's the breakdown:
Expand Down Expand Up @@ -55,7 +55,11 @@
* Helper function to make a card object.
* @returns {UNOCard} The composed UNO card.
*/
export function makeCard(type: CardType, color: CardColor, value: CardValue): UNOCard {
export function makeCard(
type: CardType,
color: CardColor,
value: CardValue
): UNOCard {
//todo: Implement unique identification of cards by assigning an id to each card
return { type, color, value, id: undefined };
}
Expand All @@ -64,7 +68,10 @@
* This function shuffles the elements of the given array *in place* . The function behaves in a type-agnostic way.
* Time complexity: O(n)
*/
export function shuffle(deck: Array<any>) {
//todo: Implement a generic shuffling algorithm
[deck[0], deck[1]] = [deck[1], deck[0]];
function shuffle(deck: Array<UNOCard>) {
// Fisher-Yates shuffle algorithm to shuffle card deck
for (let i = deck.length - 1; i > 0; i--) {
const j = Math.floor(Math.random() * i);
[deck[i], deck[j]] = [deck[j], deck[i]];
}
}
Loading