-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend: Implemented fading in & out effect on opening and closing of sidebar and modal objects #176
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left an implementation suggestion
de7f95a
to
dc9fd55
Compare
Implemented the required change |
While the sidebar enters from the right, the shadow remains in place which seems kinda awkward. We can transition the width from "w-0" to "w-64" instead of transform, and add a class to the buttons which makes them appear after the sidebar is completely in. Suggested changeSo line
The class on buttons is required since after applying the above change, during animation the buttons overflow from the sidebar div (which is expanding due to animation) After applying the above mentioned change:
|
We should try removing the setTimeout from the modal too, and change the classes as per state variables to allow fade-in animations on them, but let's leave that for sometime later. |
opening and closing of sidebar and modal objects Added tailwind transition and transform properties with state change of sidebar and modal ,giving fading effect on opening and closing. fixes shivansh-bhatnagar18#131
dc9fd55
to
ea45c72
Compare
Added the suggested change, and tried to styled the buttons to match with animation of sidebar to avoid overflowing, looks better now |
While there can still be minor amendments, I think this works |
Merged, thanks @sksmagr23 |
Description
Added tailwind transition and transform properties with state change of sidebar and modal, giving fading effect on opening and closing.
fixes #131
How to Test
Related Issues
Checklist
Screenshots
Screencast.from.2024-06-30.10-46-17.webm