Client: Make the modal system more compatible with dynamic content #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the modal system which allows the content that changes often to render dynamically. In this change you have to pass an id to the modal and if the modal with that id is opened then it will update the content inside the modal dynamically. Fixes shivansh-bhatnagar18#168
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This commits updates the existing modals to use the update function if necessary and passes id for every modal. Fixes shivansh-bhatnagar18#168
ritwik-69
force-pushed
the
fix/issue-#168
branch
from
10c0c9c to
6ff1c96
Compare
|
LGTM |
|
Merged, thanks @ritwik-69 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the modal system which allows the content that changes often to render dynamically. In this change you have to pass an id to the modal and if the modal with that id is opened then it will update the content inside the modal dynamically.
How to Test
cd frontendnpm run devRelated Issues
Checklist