Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gameStore: Added functions to add and retrieve games #12

Conversation

criticic
Copy link
Contributor

@criticic criticic commented May 28, 2024

Implemented the createGame function which creates a new game, generates it's id and adds it the the games map.

Also added the retrieveGame function which retrieves a game, given it's id.

Also added the uuid package to generate unique ids for games.

Fixes #5

Screenshots and screen captures
Self-review checklist
  • Self reviewed the changes for clarity and maintainability (variable names, code reuse, readability, etc.).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.
  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@criticic criticic force-pushed the feat/game-store-create-retrieve branch from 199c2f1 to eb9d912 Compare May 28, 2024 10:55
@criticic criticic force-pushed the feat/game-store-create-retrieve branch from 8a5cfdc to 0a4fda5 Compare May 29, 2024 19:10
Implemented the createGame function which creates a new game, generates
it's id and adds it the the games map.

Also added the retrieveGame function which retrieves a game, given it's
id.

Also added the uuid package to generate unique ids for games.

Fixes shivansh-bhatnagar18#5

Signed-off-by: Sagnik Mandal <[email protected]>
@criticic criticic force-pushed the feat/game-store-create-retrieve branch from 0a4fda5 to c5bfd63 Compare May 30, 2024 04:06
@criticic
Copy link
Contributor Author

Rebased on the recent commits

@shivansh-bhatnagar18 shivansh-bhatnagar18 merged commit 9276376 into shivansh-bhatnagar18:master May 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement game state management
2 participants