Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added About Us #111

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Conversation

Abhishek-Punhani
Copy link

Added About Us modal

Fixes : #100

Description

Added The About Us modal . Reused the structure used in rules modal

Checklist

  • I have tested these changes locally.
  • I have reviewed the code and ensured it follows the project's coding guidelines.
  • I have updated the documentation, if necessary.
  • I have assigned reviewers to this pull request.

Screenshots (if applicable)

Screenshot 2024-06-14 233304
Screenshot 2024-06-14 233312

Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
multiplayer-uno ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2024 7:22am

@@ -53,9 +51,6 @@ const Home: React.FC = () => {
/>
</div>
{showModal && <Modal onClose={() => setShowModal(false)} />}
{showRulesModal && (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These don't seem to be done by you.
Remove these

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also rebase once to make the deployment succeed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bhaiya voh maine hi remove kiya hai.....yeh already navbar mein covered hai so i removed it from home

Added About Us modal

Fixes : shivansh-bhatnagar18#100
@kuv2707 kuv2707 merged commit c08b320 into shivansh-bhatnagar18:master Jun 15, 2024
8 checks passed
@kuv2707
Copy link
Collaborator

kuv2707 commented Jun 15, 2024

Merged, thanks @Abhishek-Punhani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the About Us page
2 participants