Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: Implement Card Allotment Logic #11

Merged

Conversation

criticic
Copy link
Contributor

@criticic criticic commented May 28, 2024

This adds a check to ensure there are enough cards in the deck to allot to all players. And then distributes the cards to all players from the shuffled deck.

Fixes #3

Screenshots and screen captures
Self-review checklist
  • Self reviewed the changes for clarity and maintainability (variable names, code reuse, readability, etc.).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.
  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • [NA] Visual appearance of the changes.
  • [NA] End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@shivansh-bhatnagar18
Copy link
Owner

@criticic Can you resolve the merge conflicts and fix the Lints/Formatting. Your code LGTM otherwise and ready to be merged

@criticic
Copy link
Contributor Author

I dont get any lint errors locally, I think it might have been due to the unused variable thing

@criticic
Copy link
Contributor Author

I fixed the other PR too, i think it'll work fine now

@criticic criticic force-pushed the feat/allot-cards branch 2 times, most recently from 47daeac to 449be5d Compare May 29, 2024 19:23
This adds a check to ensure there are enough cards in the deck to allot to all players.
And then distributes the cards to all players from the shuffled deck.

Fixes shivansh-bhatnagar18#3

Signed-off-by: Sagnik Mandal <[email protected]>
@criticic criticic force-pushed the feat/allot-cards branch from 449be5d to b9a92cf Compare May 30, 2024 04:04
@shivansh-bhatnagar18 shivansh-bhatnagar18 merged commit f27c148 into shivansh-bhatnagar18:master May 30, 2024
4 of 5 checks passed
@shivansh-bhatnagar18
Copy link
Owner

@criticic There were Prettier Issues but I'll fix that for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement card allotment logic
2 participants