Skip to content

Commit

Permalink
docs: Minor updates.
Browse files Browse the repository at this point in the history
  • Loading branch information
kuv2707 committed May 26, 2024
1 parent c443dc4 commit 2fd4789
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
1 change: 1 addition & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ Maintainers will approve the issue and add relevant labels to indicate that its

- Editing commit history and rebasing are very valuable tools for keeping the commit history clean and easy to understand. Please familiarize yourself with these concepts before contributing. In any case, the seniors will be there to help you out.
- Before starting work, run `git fetch upstream` and then `git rebase upstream/master`, to rebase your branch on top of the main branch. This will help you avoid merge conflicts, and sync your branch with the main branch.
- Addressing reviews on existing PRs is as important as creating new PRs. Please be responsive to the feedback and make the necessary updates.

## Code Review

Expand Down
8 changes: 7 additions & 1 deletion CONVENTIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,13 @@
<detailed_description>
Fixes: #<issue_number>
Fixes: #<issue_number> (omit this if there is no issue associated with the commit)
```
Some examples:
```
server: Add endpoint to fetch user data.
This commit adds a new endpoint to the server that allows clients to fetch user data.
```
## Other Important Points
Expand Down
5 changes: 2 additions & 3 deletions frontend/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,12 @@ function App() {
const [count, setCount] = useState(0);
const a = 5;
console.log(a);
function handleClick() {
setCount(count + 1);
}
return (
<>
<h1>UNO!!!</h1>
<p>Lets play a game of UNO! Click the button to draw a card.</p>
<p>Card: {count}</p>
<button onClick={() => setCount(count + 1)}>Draw a card</button>
</>
);
}
Expand Down

0 comments on commit 2fd4789

Please sign in to comment.